changed static colors to dynamic theme colors in Scenario.Card.style.js and LabsWrapper.style.js#6239
changed static colors to dynamic theme colors in Scenario.Card.style.js and LabsWrapper.style.js#6239Fritozz-105 wants to merge 3 commits intolayer5io:masterfrom
Conversation
Signed-off-by: Fritozz-105 <zengz1@ufl.edu>
|
🚀 Preview for commit aca22aa at: https://67b18e68eb0cffee127bac5b--layer5.netlify.app |
|
@Fritozz-105 |
|
Thank you so much for working on this!!! 
@Fritozz-105 the alignment seems broken, we'd want to have centre aligned cards.
Additionally, @vishalvivekm suggests having coloured logos in light theme, could you ensure that's taken care of? |
|
@SAHU-01 |
Signed-off-by: Fritozz-105 <zengz1@ufl.edu>
|
🚀 Preview for commit 1ae8f1d at: https://67b657cdcb08e2ccc8624c5c--layer5.netlify.app |
Signed-off-by: Fritozz-105 <zengz1@ufl.edu>
|
🚀 Preview for commit 47d25d2 at: https://67b667e8929937f17eb6bd97--layer5.netlify.app |
Vidit-Kushwaha
left a comment
Vidit-Kushwaha
left a comment
There was a problem hiding this comment.
I find the background color of black to be a little strange. What's your thought, @vishalvivekm?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
5 participants
Description
This PR fixes #5286
Notes for Reviewers
Edited the styling files and changed the static color to blackToWhite, whiteToBlack, etc. so the color changes when toggling light/dark mode. I added a filter to the themeStyles.js because it said it wasn't advised to use a conditional for color changes.
Signed commits